SpaceEye - Adjusting reading windows for chips that fall close to the raster's boarder #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaspadilha
force-pushed
the
rpadilha/spaceeye_adjust_roi
branch
2 times, most recently
from
75cbbb7
to
2354ab8
Compare
rafaspadilha
added a commit
that referenced
this pull request
Jul 31, 2024
rafaspadilha
force-pushed
the
rpadilha/spaceeye_adjust_roi
branch
from
2354ab8
to
75dcad3
Compare
rafaspadilha
added a commit
that referenced
this pull request
Aug 1, 2024
rafaspadilha
force-pushed
the
rpadilha/spaceeye_adjust_roi
branch
from
75dcad3
to
65b9c35
Compare
robertomest
force-pushed
the
dev
branch
2 times, most recently
from
f3f687a
to
8be7698
Compare
renatolfc
approved these changes
Aug 1, 2024
rafaspadilha
force-pushed
the
rpadilha/spaceeye_adjust_roi
branch
from
65b9c35
to
adb1c30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SpaceEye workflow, if the input geometry yields a window that is smaller than the chip size, we adjust it by splitting the difference between the chip's and window's width (height) half way to the right/left (top/bottom) sides of the original window. However if the input geometry falls close to the border of the raster, we might not be able to completely increase the window in one of the sides and end up with a window smaller than the chip size. Because of that, the workflow fails with "dim_size cannot be smaller than chip_size. Please consider reducing the step/chip size or increasing the input geometry."
This PR updates the
_adjust_roi_windowmethod, so the window is adjusted from both sides until reaching the chip size or reaching the border of the raster.This fixes #180.